search

ros-industrial / abb_experimental

Experimental packages for ABB manipulators within ROS-Industrial (http://wiki.ros.org/abb_experimental)
Apache License 2.0
131 stars 115 forks source link

Cleaned up PR 112 (add 20/2.50 and 40/2.55 variants to IRB 4600) #117

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

As per subject.

This is a cleaned up version of #112, which had too many commits and a very complex commit history.

I've kept provenance on all commits.

Locally tested, seems to be working.

gavanderhoorn commented 4 years ago

As this is my "own" PR, I cannot review it any more. Hence the requests to other ros-i reviewers.

If any of you could review, I'll merge.

Note: I've reviewed this PR in its previous version (being #112). All my comments and requests have been addressed already.

gavanderhoorn commented 4 years ago

@rtonnaer: could you perhaps also verify whether you're OK with these contributions?

Perhaps @dave992 could take a look as well and verify with the hw?

gavanderhoorn commented 4 years ago

Thanks @dejaniraai. I'll give @rtonnaer and @dave992 some time to respond as well.

dave992 commented 4 years ago

Looks good! I have just tested it on the hw and everything works as expected.

gavanderhoorn commented 4 years ago

Thanks @ipa-nhg and @dave992 for checking.

I'm going to merge this.

gavanderhoorn commented 4 years ago

Thanks for all the work @rtonnaer and for iterating :100:

I'll buy you a :beer: some time.