search

ros-industrial / abb_libegm

A C++ library for interfacing with ABB robot controllers supporting Externally Guided Motion (689-1)
BSD 3-Clause "New" or "Revised" License
93 stars 53 forks source link

Add CI job to test compilation on Windows with vcpkg #101

Closed traversaro closed 4 years ago

traversaro commented 4 years ago

Fix https://github.com/ros-industrial/abb_libegm/issues/92 .

The problems discussed https://github.com/ros-industrial/abb_libegm/issues/92 were actually just due to a wrong order of arguments passed to CMake (cmake --config Release --build . seems to ignore the --build flag).

The correct compilation was tested in https://github.com/traversaro/abb_libegm/pull/2 . The CI uses https://github.com/marketplace/actions/run-vcpkg to cache the installation of vcpkg dependencies, ensuring that the build on the master branch (after the first one, that is used to populate the cache) do not take ~20 minutes.

traversaro commented 4 years ago

@gavanderhoorn I should have addressed all the comments and cleanup the commit history.

gavanderhoorn commented 4 years ago

I'm assuming we can duplicate this for abb_librws?

Or would the Poco dependency be difficult to set up?

traversaro commented 4 years ago

I'm assuming we can duplicate this for abb_librws?

Or would the Poco dependency be difficult to set up?

Fortunately poco is available as a vcpkg port (see https://github.com/microsoft/vcpkg/tree/master/ports/poco), so it should be possible to just port this to abb_librws and changing the installed dependencies.

jontje commented 4 years ago

Nice work! 😄 🎉