search

ros-industrial / abb_libegm

A C++ library for interfacing with ABB robot controllers supporting Externally Guided Motion (689-1)
BSD 3-Clause "New" or "Revised" License
93 stars 53 forks source link

Added export macro to generated protobuf C++ files, and force include generated export header #113

Closed jontje closed 3 years ago

jontje commented 3 years ago

As per title.

This is based on https://github.com/ros-industrial/abb_libegm/pull/63#issuecomment-557553377, for a solution to linking issues for shared libraries when using MSVC.

traversaro commented 3 years ago

The CI is failing with error: 

Error: Unable to process command '::set-env name=RUNVCPKG_VCPKG_TRIPLET::x64-windows' successfully.
  Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

that is because GitHub Action changed its API. It is probably sufficient to bump the version of the used run-vcpkg action to the latest one (v5.0). Indeed, you can see that it started failing two days ago in the GitHub Actions history: https://github.com/ros-industrial/abb_libegm/actions . If you want I can submit a PR to fix this.

jontje commented 3 years ago

The CI is failing with error:

Error: Unable to process command '::set-env name=RUNVCPKG_VCPKG_TRIPLET::x64-windows' successfully.
  Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

that is because GitHub Action changed its API. It is probably sufficient to bump the version of the used run-vcpkg action to the latest one (v5.0). Indeed, you can see that it started failing two days ago in the GitHub Actions history: https://github.com/ros-industrial/abb_libegm/actions .

Thanks for the quick information, I was just trying to figure out what went wrong 😅

If you want I can submit a PR to fix this.

Yes please, it would be great and much appreciated if you submit a PR.

As a side note, it looks like the same issue happens for abb_librws actions.

jontje commented 3 years ago

The Travis CI job 211.1 (ROS_DISTRO="kinetic" ROS_REPO=ros CATKIN_LINT=true) fails in the 'install_catkin_lint' function. The build target function succeeds as far as I can see.

@gavanderhoorn, do you know what the reason could be? The error is TypeError: unsupported operand type(s) for -=: 'Retry' and 'int'.

Edit: Nevermind, it seems to succeed now.

jontje commented 3 years ago

Synced with the base branch

jontje commented 3 years ago

Thanks for the help @traversaro 👍, as well as the approval @gavanderhoorn 👍