search

ros-industrial / abb_libegm

A C++ library for interfacing with ABB robot controllers supporting Externally Guided Motion (689-1)
BSD 3-Clause "New" or "Revised" License
93 stars 53 forks source link

Fix windows-vcpkg CI #156

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

I noticed in https://github.com/ros-industrial/abb_libegm/pull/155 that it was failing.

gavanderhoorn commented 1 year ago

I'd disables the Windows CI job, so closing-re-opening to trigger it.

Thanks @traversaro.

Could this change also be applied to abb_librws? I believe it uses a copy of the job we have here.

gavanderhoorn commented 1 year ago

Seems it isn't happy:

The vcpkg's Git commit id must be a full SHA1 hash (40 hex digits).
traversaro commented 1 year ago

Seems it isn't happy:

The vcpkg's Git commit id must be a full SHA1 hash (40 hex digits).

I was a bit optimistic on the support for tags. I converted it to use the corresponding commit.

traversaro commented 1 year ago

Apparently the former way of installing dependencies has been explicitly disabled: https://github.com/lukka/run-vcpkg/issues/147 .

traversaro commented 1 year ago

I think I some more time to fix this then. I will close this for now, and open it again when it is ready, sorry for the noise @gavanderhoorn .

gavanderhoorn commented 1 year ago

That's alright. Thanks for at least taking a look.

Apparently the former way of installing dependencies has been explicitly disabled: lukka/run-vcpkg#147 .

Would this need something like this: lukka/run-vcpkg/tests/theAssets/vcpkg_project/vcpkg.json instead of this line:

https://github.com/ros-industrial/abb_libegm/blob/2c9350abfb67131cae796805fed8cd6eeb2ab7f9/.github/workflows/windows-vcpkg.yml#L25

?

traversaro commented 1 year ago

That's alright. Thanks for at least taking a look.

Apparently the former way of installing dependencies has been explicitly disabled: lukka/run-vcpkg#147 .

Would this need something like this: lukka/run-vcpkg/tests/theAssets/vcpkg_project/vcpkg.json instead of this line:

https://github.com/ros-industrial/abb_libegm/blob/2c9350abfb67131cae796805fed8cd6eeb2ab7f9/.github/workflows/windows-vcpkg.yml#L25

?

Yes, based on https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json it should be sufficient to just list dependencies, no need to duplicate the name, version or other metadata.