Cleanup cmake commands to include directories

ros-industrial / abb_libegm

A C++ library for interfacing with ABB robot controllers supporting Externally Guided Motion (689-1)

BSD 3-Clause "New" or "Revised" License

96 stars 54 forks source link

Cleanup cmake commands to include directories #24

Closed traversaro closed 4 years ago

traversaro commented 6 years ago

Use target_include_directories instead of include_directories to explicitly indicate the visibility of include directories (see http://floooh.github.io/2016/01/12/cmake-dependency-juggling.html for more info)
Use the BUILD_INTERFACE generator expression to mark the local include directories as valid only for the build tree (see https://cmake.org/cmake/help/v3.12/manual/cmake-buildsystem.7.html#include-directories-and-usage-requirements)
Remove usage of catkin_LIBRARIES and catkin_INCLUDE_DIRS because they are empty.

jontje commented 6 years ago

Thanks for the PR @traversaro!

My schedule is a bit full at the moment, but I will take a closer look as soon as I find some time :)

traversaro commented 5 years ago

From https://github.com/ros-industrial/abb_libegm/pull/43#issuecomment-482064298 :

Not sure how this interacts with #24, but we'll take a look at that later.

The modifications in https://github.com/ros-industrial/abb_libegm/pull/43 are only related to the installation include directories, that are not used/referenced in this PR, so I do not think there should be any problem.

traversaro commented 5 years ago

The PR have been rebased on the top of the latest master.

traversaro commented 4 years ago

This was superseded by https://github.com/ros-industrial/abb_libegm/pull/63 , so I think we can close it.