search

ros-industrial / abb_libegm

A C++ library for interfacing with ABB robot controllers supporting Externally Guided Motion (689-1)
BSD 3-Clause "New" or "Revised" License
93 stars 53 forks source link

"No syntax specific" warning when compiling protobuf messages #72

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

We may want to add a syntax key to the .proto files we ship here (these):

[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: egm.proto.
Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
gavanderhoorn commented 4 years ago

@jontje: we can do this for the .protos we added for abb_libegm in this repository, but the main egm.proto is not maintained here.

That doesn't mean we cannot add the key, but it would be nice if "upstream" could do it as well.

jontje commented 4 years ago

That doesn't mean we cannot add the key, but it would be nice if "upstream" could do it as well.

I have mentioned it to the EGM developers.

I will add the syntax specifier to egm.proto when I update for the newest protocol version.