search

ros-industrial / abb_libegm

A C++ library for interfacing with ABB robot controllers supporting Externally Guided Motion (689-1)
BSD 3-Clause "New" or "Revised" License
93 stars 53 forks source link

Fixed method names #75

Closed jontje closed 4 years ago

jontje commented 4 years ago

As per title, so that coding style guide is followed.

Some trailing whitespaces were also automatically removed (which should have been in a separate commit).

gavanderhoorn commented 4 years ago

It's hard for me to figure out without going through everything: are any of the methods that have their name changed part of the public API?

If so: it would be nice to first deprecate the old versions, and only after some time remove them.

That way we don't break user code that may be using these functions.

So keep both the renamed and the old version around, mark the old versions as deprecated and forward invocations of the old versions to the new ones.

If all of these are internal (ie: only to be used by other functions in this library), then we don't need to do a tick-tock.

jontje commented 4 years ago

It's hard for me to figure out without going through everything: are any of the methods that have their name changed part of the public API?

No. All modified methods are intended for internal use, I should have mentioned that, my bad.

If so: it would be nice to first deprecate the old versions, and only after some time remove them.

That way we don't break user code that may be using these functions.

So keep both the renamed and the old version around, mark the old versions as deprecated and forward invocations of the old versions to the new ones.

Thanks for the advice 😃

gavanderhoorn commented 4 years ago

Thanks @jontje