ros-industrial / abb_librws

A C++ library for interfacing with ABB robot controllers supporting Robot Web Services
BSD 3-Clause "New" or "Revised" License
71 stars 61 forks source link

Add missing methods, lead-through, module / program loading #126

Open dorianleveque opened 3 years ago

dorianleveque commented 3 years ago

Hi everyone,

I recently worked on the robot Yumi (from ABB company) for a project of my school and I noticed during the development that some method was not implemented. In particular, I needed to control the lead-through and to be able to load a module and programme remotely to give position instructions to the arm joints using RAPID code.

By consulting the documentation I found out that it was simple to add the missing methods in the client and interface files. So that's what I did and I was able to test my code on a simulator (RobotStudio) and on the real robot and it works as shown in the following videos:

Can I make a pull request ?

gavanderhoorn commented 3 years ago

I'll let @jontje comment on the utility of your proposed contributions, but from a process point of view: please open PRs, preferable 1 PR per feature (or more, if it would make reviewing easier).

It's much easier to figure out whether something would make sense to merge here if the code can be inspected, and having it as a PR immediately facilitates discussion.

If in the end it's decided to not merge a PR: no problem, we just close it.

jontje commented 3 years ago

Hi @dorianleveque,

Can I make a pull request ?

Yes, you are more than welcome to create a PR, but please split it up into separate PRs as @gavanderhoorn indicated.

I will be happy to review the contributions, but just so you know, then I will be fairly preoccupied with year-end deadlines and demos until at least mid-December.