set execution permission of /ros_entrypoint.sh. Fixes issue #7.

ros-industrial / docker

ROS-Industrial docker and cloud tools

22 stars 21 forks source link

set execution permission of /ros_entrypoint.sh. Fixes issue #7. #8

Closed AustinDeric closed 7 years ago

AustinDeric commented 7 years ago

enable execute permissions of /ros_entrypoint.sh

RUN bash -c "chmod +x /ros_entrypoint.sh"

This change is only needed for the ros-core-nvidia image. All the other nvidia docker images are derived from this so no changes are needed for those images. However, they will have to be rebuilt.

gavanderhoorn commented 7 years ago

If you make the ros_entrypoint.sh script itself executable (ie: the file in the repository), you don't need to add the RUN line to the Dockerfile.

AustinDeric commented 7 years ago

As per @gavanderhoorn, I updated PR to enable execution bit of /ros_entrypoint.sh and remove RUN bash -c "chmod +x /ros_entrypoint.sh" from the Dockerfile

Thanks!

AustinDeric commented 7 years ago

Please let me know if there are any objections to merging this. Thanks again!