search

ros-industrial / industrial_calibration

Contains libraries/algorithms for calibrating industrial systems
Apache License 2.0
120 stars 88 forks source link

Increase minimum CMake version to allow builds on Focal Fossa (Noetic) #166

Closed ipa-nhg closed 3 years ago

ipa-nhg commented 3 years ago

Related to https://github.com/ros-industrial/ros_industrial_issues/issues/67

ipa-nhg commented 3 years ago

I don't know if these changes are appropriate for the current state of the repository, please review and decide if it makes sense, otherwise you can close the PR.

Levi-Armstrong commented 3 years ago

I do not see any issues here.

drchrislewis commented 3 years ago

@ipa-nhg Its true the repository is undergoing some major cleanup and upgrades. However I see no harm in these changes. I've been compiling under 20.04 noetic for quite some time. cmake is not my strong suit, so any help is welcome. If you change the status from draft, I'll merge. Let me know if you need any help whatsoever regarding calibration.

ipa-nhg commented 3 years ago

Thanks @Levi-Armstrong @drchrislewis for your reviews and comments! I changed the status now.