search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156 stars 181 forks source link

Issue #89 - fixes industrial_robot_simulator depends #106

Closed shaun-edwards closed 9 years ago

shaun-edwards commented 9 years ago

Depends on PR #105

shaun-edwards commented 9 years ago

@gavanderhoorn, could you review. This addresses your issue #89. Please verify the dependencies are now correct. I wasn't quite sure if python dependencies should be run_depend only.

shaun-edwards commented 9 years ago

@gavanderhoorn, ping/help.

gavanderhoorn commented 9 years ago

I don't believe we need all the build_depends in there (at least, not according to Python module dependencies from the catkin documentation).

Must say it's becoming increasingly unclear to me what the correct approach is for Python pkgs, but I believe only run_depends are required, unless you are depending on a message pkg.

shaun-edwards commented 9 years ago

Still depends on PR #105. I think some of the build_depends are captured as inherited dependencies and thus not needed. For now I'd like to leave them in.

shaun-edwards commented 9 years ago

@gavanderhoorn, can I merge as is?

gavanderhoorn commented 9 years ago

No; see in-line comments (args to DEPENDENCIES and python-rospkg build depend).

shaun-edwards commented 9 years ago

OK...failed to push last time...all changes should be in this PR now.

gavanderhoorn commented 9 years ago

+1.