issues
search
ros-industrial
/
industrial_core
ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156
stars
181
forks
source link
Switch ByteArray to <deque> for internal buffer
#117
Closed
JeremyZoss
closed
9 years ago
JeremyZoss
commented
9 years ago
enables dynamic sizing, for larger messages
up to INT_MAX, which is unadvised
allows efficient data access at front/rear of msgs
maintains same external API
getRawDataPtr() is deprecated (not contiguous memory)
bugFix: SimpleSocket::receiveBytes() buffer-size check
update unit tests to handle ByteArray.MaxSize==INT_MAX
JeremyZoss
commented
9 years ago
@shaun-edwards : please review
shaun-edwards
commented
9 years ago
+1