robot_status: missing reply to SERVICE_REQUEST.

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)

156 stars 181 forks source link

robot_status: missing reply to SERVICE_REQUEST. #153

Closed MariniAlberto closed 7 years ago

MariniAlberto commented 8 years ago

Fix in robot_status_message and relay_handler.

Wrong condition check at line 83 of robot_status_relay_handler.cpp (comparing CommType with MessageType). In order to fix this issue, I had to modify also the robot_status_message class, adding get* and set* methods for the comm_type attribute.

shaun-edwards commented 8 years ago

@MariniAlberto thanks for the PR. This indeed looks like a bug. The travis job seems to be failing due to socket issues, so for now we will ignore this. Just a couple of items to review.