Fix for issue #127 Uniform sample filter logging is too verbose

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)

156 stars 181 forks source link

Fix for issue #127 Uniform sample filter logging is too verbose #155

Closed mmoerdijk closed 7 years ago

mmoerdijk commented 8 years ago

Changed all relevant ROS_INFO_STREAM macros to ROS_DEBUG_STREAM macros. Now the filter only outputs the summary at the end.

shaun-edwards commented 8 years ago

Thanks for the contribution....merging.

gavanderhoorn commented 8 years ago

Not sure what happened here @shaun-edwards: the PR is still open, and github tells me that you did a "Merge branch 'indigo-devel' into fix_issue_127" (bc6a130). That is a commit in @mmoerdijk's fork.

gavanderhoorn commented 8 years ago

We might want to roll back whatever happened to avoid polluting the history too much.

shaun-edwards commented 8 years ago

After I merged #151, it said the branch needed to be updated (it didn't give me a nice green check). I clicked the "Update branch" button to make sure the build tests passed on the the latest and greatest.

Oh...it must have pulled in changes from @mmoerdijk's fork? How weird.

I'll do a manual merge. I swear these new github buttons are more trouble than they are worth.

shaun-edwards commented 7 years ago

Resubmitted in PR #158