ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)

156 stars 181 forks source link

Fixes for Kinetic #161

Closed VictorLamoine closed 7 years ago

VictorLamoine commented 7 years ago

156

shaun-edwards commented 7 years ago

@VictorLamoine, thanks for the PR. I'm working on getting some previous PRs done in indigo and jade. Once I have those branches finalized, I will create a kinetic branch for this change (I assume you are ok with that). Thursday is my ROS-I day, so you should see more activity then.

VictorLamoine commented 7 years ago

Yup, closing and waiting :)

shaun-edwards commented 7 years ago

BTW...no need to close. I can re-assign the base and approve the PR without anything else from you.

VictorLamoine commented 7 years ago

I didn't know you could re-assign the base! Good to know

shaun-edwards commented 7 years ago

Travis is foobar'ed. I'm going to approve this PR and see if the branch build fails.

Thanks everyone for the contribution. I'm going to work on a kinetic release tomorrow.