search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156 stars 181 forks source link

Fix catkin_make on kinetic-devel #169

Closed VictorLamoine closed 7 years ago

VictorLamoine commented 7 years ago

Fixes #168

VictorLamoine commented 7 years ago

So we didn't see this issue because Travis CI only builds with catkin tools. I realized this when using industrial_core in my GitLab CI: https://gitlab.com/InstitutMaupertuis/fanuc_motion/pipelines/5841251

gavanderhoorn commented 7 years ago

Yep. industrial_ci doesn't do a build with catkin_make (anymore).

@130s, @ipa-mdl.

mathias-luedtke commented 7 years ago

industrial_ci doesn't do a build with catkin_make (anymore).

Yes, this is broken. We could add it again after the refactoring (https://github.com/ros-industrial/industrial_ci/issues/98)

In addition industrial_ci disables all metapackages for some reason..

gavanderhoorn commented 7 years ago

Note: this is a partial revert of #161.