search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156 stars 181 forks source link

Use urdf::*SharedPtr instead of boost::shared_ptr #170

Closed jspricke closed 7 years ago

jspricke commented 7 years ago

urdfdom_headers uses C++ std::shared_ptr. As it exports it as a custom *SharedPtr type, we can use them to stay compatible.

jspricke commented 7 years ago

Replacement for #150 for kinetic-devel

gavanderhoorn commented 7 years ago

Wouldn't this now also work under Indigo & Jade? Because of the compatibility header?

Personally I'd like to see it in Indigo and Jade then as well.

jspricke commented 7 years ago

Yes, should be fine for all.

jspricke commented 7 years ago

should I send pull requests for them as well?

gavanderhoorn commented 7 years ago

I'll change the target for this PR to indigo-devel after Travis has completed. I think we can manage the other PRs ourselves.

shaun-edwards commented 7 years ago

@gavanderhoorn, do you want me to handle this?

VictorLamoine commented 7 years ago

@shaun-edwards CI is happy with this PR, you can merge

shaun-edwards commented 7 years ago

@VictorLamoine, sorry for the delay. Github wouldn't let me merge this a couple days back...but now it magically allowed me.