Closed jdlangs closed 3 years ago
Thanks for the PR, this looks like a useful change.
I'll submit a review shortly with some comments.
As it's just a few questions/comments really, let's not start a review yet.
CFG_EXTRAS
entry from industrial_robot_client
on purpose? Is it no longer needed?@gavanderhoorn sorry it took me a little while to come back to this. Responding to your comments:
industrial_robot_client
library and it only breaks if I remove the issue46_workaround
file from the CFG_EXTRAS
in simple_message
.Refreshed this PR for ROS-I day. This is unchanged from last year but I believe everything brought up had been addressed.
@jrgnicho would you want to take another look since you commented the first time around?
Replacement/follow-up in #262.
thanks for the initial PR @jdlangs :+1:
This fixes the problem from #188 by using the
CFG_EXTRAS
option of thecatkin_package
command to export default compiler definitions to all projects which depend onsimple_message
. It also addresses a few of the names mentioned in #65 by adding aSIMPLE_MESSAGE_
prefix to the definitions.The "documentation" of these definitions for package users is right now only in
CMakeLists.txt
and the newplatform_build_flags.cmake
file. Let me know if there is anywhere else it would be appropriate to note this behavior.