search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
154 stars 181 forks source link

Update the libraries install tags - follow the official documentation #193

Closed ipa-nhg closed 6 years ago

mathias-luedtke commented 6 years ago

This is not really needed. Please include the dummy lib as well.

mathias-luedtke commented 6 years ago

It might be even better to get rid of these dummy libs at all ;)

gavanderhoorn commented 6 years ago

Thanks for the PR @ipa-nhg.

re: dummy_lib: that is already installed here. Could you please remove it from the lines you updated or remove the install(..) statement that installs the dummy lib?

ipa-nhg commented 6 years ago

@gavanderhoorn thanks for the review, just remove this commit https://github.com/ros-industrial/industrial_core/pull/193/commits/04ee84e384d7fb20df3701a351baf87124cffa04 should be ok. I will rebase and drop it

gavanderhoorn commented 6 years ago

You just added 66e24525, was that intentional?

ipa-nhg commented 6 years ago

@gavanderhoorn no, I removed a previous commit. Probably the branch was updated (using the web interface "update branch" button yesterday??)....

gavanderhoorn commented 6 years ago

I don't know, I don't see any updates in the gh ui.

It would be good if we can keep these things separate. Could you drop 66e2452 from your LibInstallTags branch?

ipa-nhg commented 6 years ago

@gavanderhoorn Yep! done!

gavanderhoorn commented 6 years ago

Thanks again @ipa-nhg :+1: