ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156 stars 181 forks source link

catkin_lint packages #194

Closed VictorLamoine closed 3 years ago

VictorLamoine commented 6 years ago
catkin_lint -W3 .
industrial_msgs: CMakeLists.txt(5): notice: list COMPONENTS should be sorted
industrial_msgs: CMakeLists.txt(25): notice: list DEPENDENCIES should be sorted
industrial_msgs: CMakeLists.txt(29): notice: list CATKIN_DEPENDS should be sorted
industrial_robot_client: CMakeLists.txt(142): error: missing test_depend on 'rosunit'
industrial_robot_client: notice: target name 'motion_streaming_interface' might not be sufficiently unique
industrial_robot_client: notice: target name 'motion_download_interface' might not be sufficiently unique
industrial_robot_client: notice: target name 'motion_download_interface_bswap' might not be sufficiently unique
industrial_robot_client: notice: target name 'joint_trajectory_action' might not be sufficiently unique
industrial_robot_client: notice: target name 'motion_streaming_interface_bswap' might not be sufficiently unique
industrial_robot_client: CMakeLists.txt(5): notice: list COMPONENTS should be sorted
industrial_robot_client: CMakeLists.txt(28): notice: list CATKIN_DEPENDS should be sorted
industrial_robot_client: CMakeLists.txt(71): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(71): notice: list of source files should be sorted
industrial_robot_client: CMakeLists.txt(72): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(74): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(74): notice: list of source files should be sorted
industrial_robot_client: CMakeLists.txt(75): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(83): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(90): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(97): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(108): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(115): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(122): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(134): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(143): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(157): notice: use ${PROJECT_NAME} instead of 'industrial_robot_client'
industrial_robot_client: CMakeLists.txt(161): notice: list TARGETS should be sorted
industrial_robot_client: CMakeLists.txt(178): notice: extra arguments in endforeach()
industrial_robot_simulator: warning: unconfigured build_depend on 'industrial_msgs'
industrial_robot_simulator: CMakeLists.txt(5): notice: list COMPONENTS should be sorted
industrial_robot_simulator: CMakeLists.txt(8): notice: list CATKIN_DEPENDS should be sorted
industrial_robot_simulator: CMakeLists.txt(26): notice: use ${PROJECT_NAME} instead of 'industrial_robot_simulator'
industrial_trajectory_filters: error: unconfigured build_depend on 'moveit_core'
industrial_trajectory_filters: error: unconfigured build_depend on 'pluginlib'
industrial_trajectory_filters: CMakeLists.txt(20): notice: list of source files should be sorted
industrial_utils: CMakeLists.txt(24): error: missing test_depend on 'rosunit'
industrial_utils: CMakeLists.txt(18): notice: list of source files should be sorted
simple_message: CMakeLists.txt(118): error: missing test_depend on 'rosunit'
simple_message: CMakeLists.txt(122): error: missing test_depend on 'rosunit'
simple_message: CMakeLists.txt(126): error: missing test_depend on 'rosunit'
simple_message: CMakeLists.txt(130): error: missing test_depend on 'rosunit'
simple_message: warning: file 'include/simple_message/simple_message.h' is executable but not installed
simple_message: warning: file 'include/simple_message/byte_array.h' is executable but not installed
simple_message: warning: file 'include/simple_message/smpl_msg_connection.h' is executable but not installed
simple_message: warning: file 'src/simple_message.cpp' is executable but not installed
simple_message: warning: file 'src/smpl_msg_connection.cpp' is executable but not installed
simple_message: CMakeLists.txt(5): notice: list COMPONENTS should be sorted
simple_message: CMakeLists.txt(18): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(70): notice: list CATKIN_DEPENDS should be sorted
simple_message: CMakeLists.txt(100): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(100): notice: list of source files should be sorted
simple_message: CMakeLists.txt(101): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(102): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(105): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(105): notice: list of source files should be sorted
simple_message: CMakeLists.txt(106): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(107): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(108): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(111): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(111): notice: list of source files should be sorted
simple_message: CMakeLists.txt(112): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(113): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(114): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(120): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(124): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(128): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(132): notice: use ${PROJECT_NAME} instead of 'simple_message'
simple_message: CMakeLists.txt(136): notice: use ${PROJECT_NAME} instead of 'simple_message'

@ipa-nhg if you have some time you could improve the packages by following the guidelines of catkin_lint, it's usually very helpful to get clean packages.

ipa-nhg commented 5 years ago

Fixed: https://github.com/ros-industrial/industrial_core/pull/233