Closed AustinDeric closed 5 years ago
@shaun-edwards, @AustinDeric: with the change being bw-compatible with Kinetic I would prefer to not fork for Melodic and just release current kinetic-devel
. This is done in multiple other ROS pkgs, so we could follow those examples.
If/when changes are introduced that necessitate a fork, we can always do that.
As to the Travis config: to make sure any commit works on both versions, we should probably just add both Kinetic and Melodic entries to the .travis.yml
file.
@gavanderhoorn That works for me!
My intention was just to test against melodic and subsequently bloom-release this to melodic. It looks like all those intentions are satisfied with your approach.
UPDATE: The latest commit to this PR branch makes all the proposed fixes and is ready for merge.
Any activity on this one?
Friendly ping :pig: I don't think anything is holding the release!
I think we just need a merge and a bloom release! ping @Levi-Armstrong
the actual file changes were minor. Changed <class_loader/class_loader.h> to <class_loader/class_loader.hpp> as per a compiler warning.
I haven't tested it on actual hardware, but it builds: