ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156 stars 181 forks source link

release melodic-devel #204

Closed AustinDeric closed 5 years ago

AustinDeric commented 6 years ago

the actual file changes were minor. Changed <class_loader/class_loader.h> to <class_loader/class_loader.hpp> as per a compiler warning.

I haven't tested it on actual hardware, but it builds:

FROM osrf/ros:melodic-desktop-full-bionic

RUN apt-get update && apt-get install -y \
    ros-melodic-moveit \
    python-rosinstall \
    python-rosinstall-generator \
    python-wstool \
    build-essential \
    python-pip \
    nano \
    gdb \
    && rm -rf /var/lib/apt/lists/*

RUN pip install --upgrade pip

RUN pip install -U catkin_tools

RUN mkdir -p /root/ros_libs/src

WORKDIR /root/ros_libs/src

RUN git clone -b melodic-devel https://github.com/AustinDeric/industrial_core.git

WORKDIR /root/ros_libs/

RUN /bin/bash -c "source /opt/ros/melodic/setup.bash && catkin build && catkin install"
gavanderhoorn commented 6 years ago

@shaun-edwards, @AustinDeric: with the change being bw-compatible with Kinetic I would prefer to not fork for Melodic and just release current kinetic-devel. This is done in multiple other ROS pkgs, so we could follow those examples.

If/when changes are introduced that necessitate a fork, we can always do that.

As to the Travis config: to make sure any commit works on both versions, we should probably just add both Kinetic and Melodic entries to the .travis.yml file.

AustinDeric commented 6 years ago

@gavanderhoorn That works for me!

My intention was just to test against melodic and subsequently bloom-release this to melodic. It looks like all those intentions are satisfied with your approach.

UPDATE: The latest commit to this PR branch makes all the proposed fixes and is ready for merge.

jorgenfb commented 6 years ago

Any activity on this one?

VictorLamoine commented 6 years ago

Friendly ping :pig: I don't think anything is holding the release!

AustinDeric commented 6 years ago

I think we just need a merge and a bloom release! ping @Levi-Armstrong