search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
154 stars 181 forks source link

Trajectory filters: check output of update method #217

Closed marip8 closed 5 years ago

marip8 commented 5 years ago

I recently ran into an issue with a trajectory filter (uniform sampling filter) which had been accidentally given a bad input trajectory such that the update method returned false. The adaptAndPlan method did not check the output of the update method which subsequently resulted in an exception being thrown elsewhere in the move_group code. This PR checks the call to the update method before continuing to write the new output trajectory to avoid issues later in the planning/execution pipeline

gavanderhoorn commented 5 years ago

Thanks @marip8 :+1: