Closed gavanderhoorn closed 5 years ago
Thanks, and we will have the team take a closer look moving forward. Shaun has expressed interest in continuing to maintain Motoman related repos, but even those should be updated to his current email address.
MR
On Thu, Feb 28, 2019, 6:58 AM G.A. vd. Hoorn notifications@github.com wrote:
As per subject.
Noticed that Shaun's old SwRI address was still listed in all packages.
You can view, comment on, or merge this pull request online at:
https://github.com/ros-industrial/industrial_core/pull/222 Commit Summary
- all: update maintainer email addresses.
File Changes
- M industrial_core/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-0 (4)
- M industrial_deprecated/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-1 (4)
- M industrial_msgs/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-2 (4)
- M industrial_robot_client/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-3 (2)
- M industrial_robot_simulator/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-4 (2)
- M industrial_trajectory_filters/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-5 (4)
- M industrial_utils/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-6 (4)
- M simple_message/package.xml https://github.com/ros-industrial/industrial_core/pull/222/files#diff-7 (2)
Patch Links:
- https://github.com/ros-industrial/industrial_core/pull/222.patch
- https://github.com/ros-industrial/industrial_core/pull/222.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ros-industrial/industrial_core/pull/222, or mute the thread https://github.com/notifications/unsubscribe-auth/AdNiEJ0OjTVps0IL4HVr7wWYn_PyPWdOks5vR9JugaJpZM4bWwi0 .
Can we please get this merged first? I'd like to not have invalid email addresses in package manifests, even if the listed address is not the preferred maintainer any longer.
We can then start the discussion on who should be listed where.
To move forward, I need a review from at least one other maintainer with write access.
:bellhop_bell: @Levi-Armstrong or @shaun-edwards.
@gavanderhoorn thanks for the update
As per subject.
Noticed that Shaun's old SwRI address was still listed in all packages.