search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
154 stars 181 forks source link

fix #225: incorrect return value if deserializing duration fails #226

Closed gonzalocasas closed 5 years ago

gonzalocasas commented 5 years ago

As discussed in #225, the JointTrajPt will return true even if deserializing duration failed. This is the smallest possible fix, just removing the line that incorrectly set rtn=true.

gavanderhoorn commented 5 years ago

Travis problems .. I've restarted it (known problem).

gavanderhoorn commented 5 years ago

rosdep/GH is being annoying.

Edit: it's actually GH probably.

gonzalocasas commented 5 years ago

@gavanderhoorn ping 😉

gavanderhoorn commented 5 years ago

Restarted Travis. Let's see whether things will compile this time.

gavanderhoorn commented 5 years ago

Thanks @gonzalocasas for the fix.

Much appreciated :+1: