Closed seanyen closed 4 years ago
@gavanderhoorn Hope I am reaching out the correct owner. Any feedback would be really appropriated. Once industrial_core
is enabled for Windows build, I am planning to swap our fork for the upstream repository in our build farm. https://ms-iot.github.io/ROSOnWindows/Build/buildfarm.html
Thanks!
@gavanderhoorn Just a friendly ping. This is ready for review and merge. Please let me know any feedback. Thanks!
This pull request is to address the issues found when I was bringing up
industrial_core
on Windows.catkin
guide to install binaries to the portable location inCMakeLists.txt
.variable length array
usage withstd::vector
for portability.##__va_args__
inlog_wrapper.h
, since MSVC doesn't support it.ws2_32.lib
linkage for Windows build.