[Windows][kinetic-devel] Fixed Windows build breaks.

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)

154 stars 181 forks source link

[Windows][kinetic-devel] Fixed Windows build breaks. #236

Closed seanyen closed 4 years ago

seanyen commented 5 years ago

This pull request is to address the issues found when I was bringing up industrial_core on Windows.

Follow catkin guide to install binaries to the portable location in CMakeLists.txt.
Replace variable length array usage with std::vector for portability.
Define a fallback implementation for GCC extension ##__va_args__ in log_wrapper.h, since MSVC doesn't support it.
Conditionally include Windows socket headers & add required ws2_32.lib linkage for Windows build.

seanyen commented 5 years ago

@gavanderhoorn Hope I am reaching out the correct owner. Any feedback would be really appropriated. Once industrial_core is enabled for Windows build, I am planning to swap our fork for the upstream repository in our build farm. https://ms-iot.github.io/ROSOnWindows/Build/buildfarm.html

Thanks!

seanyen commented 4 years ago

@gavanderhoorn Just a friendly ping. This is ready for review and merge. Please let me know any feedback. Thanks!