[Windows][kinetic-devel] Fixed Windows build breaks.

seanyen commented 4 years ago

(I use this one to replace #236.)

This pull request is to address the issues found when I was bringing up industrial_core on Windows.

Follow catkin guide to install binaries to the portable location in CMakeLists.txt.
Replace variable length array usage with std::vector for portability.
Define a fallback implementation for GCC extension ##__va_args__ in log_wrapper.h, since MSVC doesn't support it.
Conditionally include Windows socket headers & add required ws2_32.lib linkage for Windows build.

seanyen commented 4 years ago

@gavanderhoorn This is ready for review and merge. Thanks!

drostifrosti commented 3 years ago

I was able to successfully compile the fanuc_driver package with this PR under melodic and noetic in native Windows.

gavanderhoorn commented 3 years ago

Rebased version in #264.

Thanks for the initial PR @seanyen :+1:

ros-industrial / industrial_core