search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
156 stars 181 forks source link

noetic compatibility #258

Closed simonschmeisser closed 3 years ago

simonschmeisser commented 4 years ago

see #256 as well

simonschmeisser commented 4 years ago

@TheDelus please test this

@gavanderhoorn friendy ping for review

fmessmer commented 3 years ago

@simonschmeisser I can confirm this PR compiles on Noetic... ...just one minor addition: https://github.com/simonschmeisser/industrial_core/pull/1

fmessmer commented 3 years ago

@gavanderhoorn @shaun-edwards @ipa-nhg what else do you need for this pr to get merged and to trigger a new release for noetic afterwards?

gavanderhoorn commented 3 years ago

Some free time.

Although the reviews are appreciated, more :+1: or approvals will not make that happen earlier.

fmessmer commented 3 years ago

a month later, I dare to ask what the review status of this PR is atm...

ranjitkathiriya commented 3 years ago

Successfully compiled on Ubuntu 20.04 and noetic.

JGroxz commented 3 years ago

Reconfirming, successfully compiled on Ubuntu 20.04 and Noetic.

o0stinger0o commented 3 years ago

RE:Reconfirming, successfully compiled on Ubuntu 20.04 and Noetic.

Levi-Armstrong commented 3 years ago

@gavanderhoorn You good with me merging this PR?

gavanderhoorn commented 3 years ago

Thanks @simonschmeisser for the fixes.

I've created a melodic-devel branch and merged the PR there, to prevent importing new changes into kinetic-devel.