search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
153 stars 180 forks source link

Rebased 251: Fixed Windows build breaks #264

Closed gavanderhoorn closed 3 years ago

gavanderhoorn commented 3 years ago

Rebased version of #251 which makes simple_message and industrial_robot_client et al. build on Windows.

Tested against Roboguide with fanuc_driver on Ubuntu. No regressions detected. Tests still pass.

I haven't been able to test this on Windows, as I don't have access to a suitable Windows installation.

I trust @seanyen has though, and https://github.com/ros-industrial/industrial_core/pull/251#issuecomment-756997087 reports another success by an additional user.

gavanderhoorn commented 3 years ago

I'm going to merge this after we get a green CI checkmark.

I've reviewed the original #251.

gavanderhoorn commented 3 years ago

Thanks again @seanyen for the PR.