search

ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
153 stars 180 forks source link

Rebased 246: receive timeouts for simple socket #267

Closed gavanderhoorn closed 3 years ago

gavanderhoorn commented 3 years ago

As per subject.

Commit provenance and attribution retained, although the original account appears to have been deleted.

One additional commit fixes some style issues.

gavanderhoorn commented 3 years ago

We'll merge this, although this isn't actually used anywhere. Not in IRC nor in any of the drivers we maintain which use simple_message or the IRC.

As such, it's difficult for me to test it, and I can only rely on the review that was already done in #246 and the unit test that was added as part of the PR (which is great of course).

gavanderhoorn commented 3 years ago

As the original PR already had been reviewed, I'm going to merge this without an additional review.

gavanderhoorn commented 3 years ago

Thanks Tim Perkins for the initial PR.