ros-industrial / industrial_core

ROS-Industrial core communication packages (http://wiki.ros.org/industrial_core)
153 stars 180 forks source link

- Portability on ROS1 Noetic. #278

Closed giordy-sudo closed 2 years ago

giordy-sudo commented 2 years ago

Hello, I have some issues when I compile (catkin build) these packages :

In particular errors are :

Industrial_robot_client_1 Industrial_robot_client_2

Industrial_utils

Thanks a lot.

gavanderhoorn commented 2 years ago

You appear to use a fork of industrial_core.

All industrial_core packages have been released for ROS Noetic, and CI runs regularly (see here for the latest run on Ubuntu Focal).

It's likely the fork is outdated.

gavanderhoorn commented 2 years ago

Closing as this is not an issue with the packages in this repository.

gavanderhoorn commented 2 years ago

PS: and please, do not post screenshots of terminals.

It's all text, so copy-paste the errors as text into your github issue.

Do make sure to use fenced codeblocks though.

giordy-sudo commented 2 years ago

Hello, thanks. Also withe the modifications that you sent me I still have the same errors. I apply these changes : https://github.com/ros-industrial/industrial_core/commit/ea3d805e1271550be312409d6474177e67796e15.

gavanderhoorn commented 2 years ago

I'm not sure I understand.

I have not sent you any modifications.

I apply these changes : ea3d805.

cherry-picking a single commit will not solve the problem.

giordy-sudo commented 2 years ago

Ok sorry can you explain in a simple way how can I solve my problem ? Thanks.

gavanderhoorn commented 2 years ago

I would suggest to ask the maintainers of the fork you are trying to use.

I don't know what their motivation for forking was, and I don't know what changes they've made to the code.

At a high level, you'd have to merge the differences between their fork and upstream (ie: this repository).

giordy-sudo commented 2 years ago

So who are the maintainers of the fork I'm trying to use ?

gavanderhoorn commented 2 years ago

I have no idea.

Wouldn't you be the one who knows what he's git clone-ing?