ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
425 stars 237 forks source link

Open Items #114

Open geoffreychiou opened 7 years ago

geoffreychiou commented 7 years ago

I will be using this issue to keep track of the open items provided by Jeremy and Austin as I fix them.

HIGHER-PRIORITY

Wiki

Git

Austin

Paul

geoffreychiou commented 7 years ago

@AustinDeric

Section 5.1 Testing:

Git

The git solution does not have any of the folders that were to be created per the instructions in the wiki.

Wiki

ASSERT(true) produced an error for me. Did you mean to have something else there? A quick glance through the googletest documentation shows that they have "ASSERT_TRUE(condition)" and "ASSERT_FALSE(condition" but nothing with just ASSERT(condition).

Section 5.3 Testing

Wiki

The instructions at the end suddenly use catkin_make while all the previous instructions all used catkin build. I was not able to get it to work. Any suggestions?

geoffreychiou commented 7 years ago

PR made for Exercise 4.3.

geoffreychiou commented 7 years ago

@Levi-Armstrong @AustinDeric The Wiki references recap slides that I do not have. Are those slides actually used in the lectures? if not, can we remove the link to those slides from the Wiki?.

geoffreychiou commented 7 years ago

@AustinDeric Ran through the Perception Driven demo setup in simulation and everything worked. We should probably wait until next time the classes come around to do robot testing again.