search

ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
428 stars 238 forks source link

Overlaying doesn't work with current training unit script #24

Open shaun-edwards opened 10 years ago

shaun-edwards commented 10 years ago

Overlaying does not work when a supplements package and a debian package are both installed on the same system. Steps to reproduce:

  1. Install the motoman hydro package: 'sudo apt-get install ros-hydro-motoman'
  2. Run training unit 2.6 with 'robot:=sia20d

The package should successfully open an sia20d in rviz.

  1. Edit the sia20d URDF file under the supplements (create an error)
  2. Run the training unit again

The package still successfully opens because the supplements is not properly overlaying. NOTE: Static ros commands, like 'roscd', still work.

shaun-edwards commented 10 years ago

It appears that overlaying in catkin only requires calling the devel/setup.sh scrips in the appropriate order(see the end of this section ). By creating a workspace in the supplements and then overlaying each training unit on top of it, this problem may be solvable.

shaun-edwards commented 10 years ago

@malban checked in a possible fix ( 911f9a1f1757ce17496bc8589fd843f5a87f0316 ). It seems to work in most cases but not in the case of URDFs (the $find macro seems to find the wrong package path). Another alternative may be to use softlinks to package directories in the supplements workspace. @jrgnicho, may consider this approach if there are problems in the demo.

shaun-edwards commented 10 years ago

This issue was addressed enough for Hydro...may consider different approach for Indigo.