ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
417 stars 234 forks source link

Converted demo 1 instructions to reStructuredText #325

Closed max-sn closed 3 years ago

max-sn commented 3 years ago

Includes:

marip8 commented 3 years ago

I think this looks really good; thanks for putting this together. I have a few minor formatting changes that I would like to add before merging. Would you mind allowing edits by maintainers for this PR (should be a check-box on this page at the bottom right)? It's a little easier for me to push the commit directly on to this branch as opposed to opening a PR against your fork.

max-sn commented 3 years ago

I don't see such a checkbox on this page, could that be because I'm not formally the owner of the fork? (It says here that to enable that it should be a user-owned fork: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork)

marip8 commented 3 years ago

No problem. I've attached the commit as a patch below instead. You should be able to apply it to this branch by running the following command on your branch:

git am minor-formatting-changes.patch

minor-formatting-changes.patch.zip

max-sn commented 3 years ago

That's a great feature! Thanks for the changes by the way, some things I noticed already but I was unsure whether I should change them, but other things I completely missed.

marip8 commented 3 years ago

Thanks for the contribution and documentation improvement