search

ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
417 stars 234 forks source link

Tutorial Part 3.2 not up-to-date. #331

Open JoeGre666 opened 3 years ago

JoeGre666 commented 3 years ago

Hey, I'm currently trying to do ROS Industrial (Melodic) Training Exercises 3.2. I did everything as in the instructions, but always got errors. According to the error message there is no buffer.h / transform_listener.h in the package tf2, so I looked it up and found the matching header files in the tf2_ros package (look at instructions).

Screenshot from 2020-11-09 18-04-09

So I tried including those packages, still errors. After a few more tries I looked in the exercise-files and found out that I was right about the tf2_ros-package, but additionally the <tf2_geometry_msgs/tf2_geometry_msgs.h> header-file is missing (screenshot is from exercise files - for reference). This is not mentioned in the instructions at all.

Screenshot from 2020-11-09 18-02-09

Since I was a bit frustrated, I suggest to maybe adjust this? :) Apart from that - great tutorial. Kind regards, Johannes

basalp commented 3 years ago

Thank you for the suggestions, this is really helpful. Without the <tf2_geometry_msgs/tf2_geometry_msgs.h> package, the catkin build was complaining for a reason that I did not understand for a while. Addition of it solved the issue. With that, explicit #include <geometry_msgs/PoseStamped.h> becomes obsolete as the former package also includes it.

marip8 commented 3 years ago

Thanks for catching this issue. It seems like we actually changed the solution to the exercise here to be correct, but we didn't catch the header references in the exercise documentation.