search

ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
417 stars 234 forks source link

WIP: Update 1-Workcell-XACRO.md #346

Closed DavidMerzJr closed 2 years ago

DavidMerzJr commented 3 years ago

Fixes to various common areas encountered during the training.

DavidMerzJr commented 3 years ago

Please don't merge until after the training.

DavidMerzJr commented 3 years ago

We also need to update the ROS2 solution for exercise 3.3, as the controllers.yaml has not been updated from its ROS1 format.

jdlangs commented 3 years ago

I don't believe it should be part of the exercise contents to check for and install dependencies. Ideally these packages should be in a list for either the automated setup or configuration check scripts to use.

It may be useful to explicitly label a Dependencies section in each exercise that needs them so we could easily join them together for a comprehensive list and then students would also see what packages need to be used.

JeremyZoss commented 2 years ago

I agree with Josh. This should be handled with an update to the setup/check scripts. We can add an issue to track Josh's suggestion to more explicitly define the dependencies for each individual exercise, then probably close this issue.

JeremyZoss commented 2 years ago

Added referenced dependencies (ros-foxy-joint-state-publisher-gui and ros-foxy-xacro) to setup script in #361. Exercise 3.3 controllers.yaml updated in #356. This PR is no longer needed.