search

ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
417 stars 234 forks source link

Fixing typos in the first three demo pages #352

Closed Lrk114 closed 2 years ago

Lrk114 commented 2 years ago

Fixed typos in the first three demo pages -- hope this helps..

jdlangs commented 2 years ago

Just thought I'd leave a quick friendly comment: fixing typos is of course always welcome, but it seems the majority of the changes here are style choices/rephrasing. And some, as Jorge pointed out, seem to be more confusing the original. I would be very circumspect about coming to an open-source repo and suggesting such changes in general as it asks maintainers to do work with arguably no substantial benefit to the repository. Obviously there's a balance as lots of open-source text could use more rephrasing and clarity; I would just make sure to consider the benefit is worth taking a reviewer's time.

Lrk114 commented 2 years ago

Many thanks for your reviews -- changes made, maybe should be squashed when merging?