search

ros-industrial / industrial_training

ROS-Industrial Training Material
https://industrial-training-master.readthedocs.io
Apache License 2.0
417 stars 234 forks source link

Typos in Session 2.2 #362

Closed DavidMerzJr closed 2 years ago

DavidMerzJr commented 2 years ago

Two small typos in Session 2.2 found during the dry run. The first is missing the .py extension. Regarding the second one, we currently describe the purpose of output='screen' and say 'see below', but do not include the indicated changes.

JeremyZoss commented 2 years ago

The output="screen" section is getting a bit wordy. Especially since it doesn't really do anything right now (launch files direct INFO/WARN logs to console, even without adding output="screen"). I'd prefer to leave the launch file as-is (no output="screen") and remove most of the related text. We could leave a single sentence saying something like: "if Node log messages are shown when run directly (ros2 run...) but not when run from a launch file, try adding output="screen" to the Node action input arguments.

Perhaps we leave the existing content in-place but disable with HTML comments (<-- .... -->). Or just delete it and refer back to the git history if we want to re-add later once launch-file console logging is again working as expected.

Reconsidered. This is fine as-is. @DavidMerzJr Please merge when you get a chance.