search

ros-industrial / kuka_experimental

Experimental packages for KUKA manipulators within ROS-Industrial (http://wiki.ros.org/kuka_experimental)
Apache License 2.0
277 stars 217 forks source link

Indigo ci #203

Closed simonschmeisser closed 3 years ago

simonschmeisser commented 3 years ago

I slightly messed up indigo compatibility when merging #199 instead of #139 to indigo-devel. This restores compatibility with indigo (it has been "broken" already since at least 2018 however) and enables CI for it to prevent future regressions

gavanderhoorn commented 3 years ago

Let's not merge any more changes into indigo-devel.

simonschmeisser commented 3 years ago

Let's not merge any more changes into indigo-devel.

Agreed, I just wanted to ensure it's functional before sealing it off and archiving it. I assume your positive review indicates that this PR can and should still be merged but nothing beyond that?

gavanderhoorn commented 3 years ago

Yes, correct.

gavanderhoorn commented 3 years ago

Would you want to merge this @simonschmeisser ?

Or are you waiting for something else to go in first?

simonschmeisser commented 3 years ago

Just need an approval :)

gavanderhoorn commented 3 years ago

Oh, the review was dismissed.

simonschmeisser commented 3 years ago

Thanks, maybe I should stop pushing those final commits the moment you press "Approve" ...