search

ros-industrial / kuka_experimental

Experimental packages for KUKA manipulators within ROS-Industrial (http://wiki.ros.org/kuka_experimental)
Apache License 2.0
268 stars 213 forks source link

Increase minimum CMake version to allow builds on Focal Fossa (Noetic) #206

Closed ipa-nhg closed 3 years ago

ipa-nhg commented 3 years ago

Related to https://github.com/ros-industrial/ros_industrial_issues/issues/67

simonschmeisser commented 3 years ago

I would prefer going to 3.1 as that enables the SET(CMAKE_CXX_STANDARD 11) as discussed in https://github.com/ros-industrial/kuka_experimental/pull/204#discussion_r718528526

3.7.2 would be the minimum recommended version for melodic so 3.1 is fine

ipa-nhg commented 3 years ago

As I made the change recursively for all the ROS-I repos I used the minimum recommended version for kinetic, just to be sure that I don't break any of them.

gavanderhoorn commented 3 years ago

This (or #204 for that matter) drops kinetic compatibility, I'm fine with that, are you as well @gavanderhoorn ?

the PR is against melodic-devel, so yes, that would be ok.

gavanderhoorn commented 3 years ago

Btw, we'd only need 3.1 on the two drivers.

The rest are simple support packages, which don't compile anything.

That might help Kinetic users (of which there are still many apparently).

simonschmeisser commented 3 years ago

true, would that asking for too much @ipa-nhg ? You could also go back to 3.0.2 and I'll increment it in #204 for the two packages where it is needed

ipa-nhg commented 3 years ago

@simonschmeisser no problem, is done!

gavanderhoorn commented 3 years ago

@simonschmeisser: should this have been a squash-merge? ;)

simonschmeisser commented 3 years ago

yes, you're right, that would look better