search

ros-industrial / kuka_experimental

Experimental packages for KUKA manipulators within ROS-Industrial (http://wiki.ros.org/kuka_experimental)
Apache License 2.0
268 stars 213 forks source link

Kr150 r3100 2 #208

Closed axelschroth closed 2 years ago

axelschroth commented 2 years ago

Add Kuka KR150 R3100-2

simonschmeisser commented 2 years ago

Please rebase this to melodic-devel and include only the last commit (rebase --onto) and change the target branch to melodic-devel

axelschroth commented 2 years ago

Done @simonschmeisser

gavanderhoorn commented 2 years ago

Looking at #198, shouldn't the variant name be kr150r3100_2? There seems to be an extra _ between kr150 and r3100_2.

simonschmeisser commented 2 years ago

And please include the opw parameter file and add tests by renaming https://github.com/ros-industrial/kuka_experimental/blob/melodic-devel/kuka_kr150_support/test/roslaunch_test.xml and creating a copy for this variant. Then add it to the CMakeLists.txt

axelschroth commented 2 years ago

Thanks for your feedback! I adapted all of your suggestions.

axelschroth commented 2 years ago

I believe kuka_kr150_support/config/opw_parameters_kr150_r3100-2.yaml should be renamed to kuka_kr150_support/config/opw_parameters_kr150r3100_2.yaml.

Thanks, missed that one!

gavanderhoorn commented 2 years ago

@simonschmeisser @axelschroth: is this waiting on something from my side?

simonschmeisser commented 2 years ago

Looks like I cannot overrule your "changes requested" state and thus merge