search

ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
146 stars 193 forks source link

Version reference fixed to 1.9.5 #413

Closed EricMarcil closed 3 years ago

EricMarcil commented 3 years ago

Fixed version reference that was forgotten in the PR #412

gavanderhoorn commented 3 years ago

I realise FS100 and DX100 don't show these versions anywhere, but it would be good to include the complete set of updated binaries in this PR.

That'll make it that much easier to reason about what changed in the future, and easier to match binaries to Git hashes.

EricMarcil commented 3 years ago

Yes, I saw that the FS100 and DX100 binary were not included but I actually compiled them. GitHub won't pick them up because the resulting compiled binary doesn't actually change.

gavanderhoorn commented 3 years ago

GitHub won't pick them up because the resulting compiled binary doesn't actually change.

Ok, thanks for confirming that.

gavanderhoorn commented 3 years ago

Unfortunately this will mean you'll have to update the wiki again @EricMarcil. At least for the affected binaries.

EricMarcil commented 3 years ago

@gavanderhoorn I expected that. It's done and I've confirmed that the downloaded .out was matching the MD5 hash. Thanks for the quick turn around.