search

ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
146 stars 195 forks source link

driver: add missing MotionReply sub codes #438

Closed gavanderhoorn closed 2 years ago

gavanderhoorn commented 2 years ago

As per subject.

Noticed they were missing while working on #435 and #436.

This will only improve the "human side" of motoman_driver. The error (sub) codes were processed correctly before this PR, but the human readable error message just converted them to "unknown" errors.

gavanderhoorn commented 2 years ago

Perhaps @steviedale could (also) take a look?

gavanderhoorn commented 2 years ago

As I dismissed the review with my last commit, we're going to need another approval before this can be merged.

gavanderhoorn commented 2 years ago

Thanks for the reviews @marip8 and @EricMarcil :+1: