search

ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
146 stars 192 forks source link

Joint naming convention #443

Closed ted-miller closed 2 years ago

ted-miller commented 2 years ago

I received a support request from a user who is getting the error Failed to find topic_list parameter. Following the advice from here and here, we determined that controller_joint_names was not set correctly.

It seems that naming convention changed at some point to include the joint number. (joint_s to joint_1_s)

This is problematic because the usage tutorial doesn't show the new convention. Looking through the various support packages, some older robot models (such as MH5) are still using the old convention.

Which is better:

  1. Update the tutorial to show both possible methods and advise the user to check the yaml file first.
  2. Update the older packages to the new convention and then change the tutorial. (Are there any consequences to update the older packages to use the new convention?)
acbuynak commented 2 years ago

+1 for updating older packages to the new convention, but it may be prudent to note the old convention in the tutorial if people reference older forks of the support package.

I work with an MH5 (long-variant) on a daily basis, but understand them to be less common. And have an old open PR #380 which updated multiple things with the MH5 support package including the change in naming convention.