search

ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
146 stars 192 forks source link

Add support for base GP180 variant (rebased #395) #479

Closed gavanderhoorn closed 2 years ago

gavanderhoorn commented 2 years ago

Finally had time to rebase this and add some fixups.

Original PR by @Doomerdinger in #395.

Commit provenance retained, rebased on-top of current kinetic-devel.

The motoman_resources part of #395 was already merged as part of #405.

Note: I've not re-oriented the joints, nor the links. As such, this variant's xacro:macro deviates from all other models in this repository. I did add a note about this to the package's manifest.

Afaict, this PR is OK to merge like this.

gavanderhoorn commented 2 years ago

Seems GH actions is having a bit of a difficult day.

gavanderhoorn commented 2 years ago

As I've reviewed the original PR, I'm going to merge this one -- which is essentially just a rebase -- without waiting on a review.

gavanderhoorn commented 2 years ago

Using a squash-merge again, as we don't want all the fixups to end up in the history.

gavanderhoorn commented 2 years ago

Thanks again for the work @Doomerdinger :+1: