search

ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
146 stars 192 forks source link

downgrade scary log message to INFO instead, provide default controller TCP port #483

Closed cjue closed 2 years ago

cjue commented 2 years ago

The Failed to find topic_list parameter error message is too aggressive as this is the normal case when there is just one arm connected.

The Failed to get '~port' parameter: using default (50242) warning can be avoided by just adding this default parameter explicitly to io_relay.launch.

Thanks to @gavanderhoorn for your feedback.

gavanderhoorn commented 2 years ago

Closing as I believe #484 and #485 are improvements on the change(s) proposed here.

gavanderhoorn commented 2 years ago

Thanks for submitting the PR @cjue. That's always appreciated :+1: