Open nardavin opened 2 years ago
Thanks for the PR. It includes some interesting ideas.
c4533d3 seems to mimic ros-industrial/industrial_core#271, but makes it Motoman-specific.
d1cd81a is a nice idea, but on my test setup (YRC1000, 4 groups) results in all goals to always be ABORTED
with:
[ WARN] [...] [/arm_controller/follow_joint_trajectory]: Outside goal constraints, aborting trajectory
[ INFO] [...] [/arm_controller/follow_joint_trajectory]: Aborting active goal.
[ INFO] [...] [/motion_streaming_interface]: Receiving joint trajectory message Dynamic
[ INFO] [...] [/motion_streaming_interface]: Empty trajectory received, canceling current trajectory
[ INFO] [...] [/move_group]: Controller 'arm_controller' successfully finished
[ WARN] [...] [/move_group]: Controller handle arm_controller reports status ABORTED
[ INFO] [...] [/move_group]: Completed trajectory execution with status ABORTED ...
[ INFO] [...] [/move_group]: Execution completed: ABORTED
f513b1e is also a nice idea. I'm wondering though, similar code is include here:
I guess you observed that dtor to not always successfully disable trajectory mode?
Thanks for the PR. It includes some interesting ideas.
c4533d3 seems to mimic ros-industrial/industrial_core#271, but makes it Motoman-specific.
d1cd81a is a nice idea, but on my test setup (YRC1000, 4 groups) results in all goals to always be
ABORTED
with:[ WARN] [...] [/arm_controller/follow_joint_trajectory]: Outside goal constraints, aborting trajectory [ INFO] [...] [/arm_controller/follow_joint_trajectory]: Aborting active goal. [ INFO] [...] [/motion_streaming_interface]: Receiving joint trajectory message Dynamic [ INFO] [...] [/motion_streaming_interface]: Empty trajectory received, canceling current trajectory [ INFO] [...] [/move_group]: Controller 'arm_controller' successfully finished [ WARN] [...] [/move_group]: Controller handle arm_controller reports status ABORTED [ INFO] [...] [/move_group]: Completed trajectory execution with status ABORTED ... [ INFO] [...] [/move_group]: Execution completed: ABORTED
I suspect something more subtle is going on here. Do the trajectories succeed on 01146c8
? Not sure how adding the timer constraint would cause the trajectories to be aborted.
f513b1e is also a nice idea. I'm wondering though, similar code is include here:
I guess you observed that dtor to not always successfully disable trajectory mode?
Correct - I'm not sure what was going on here, but adding the explicit sigterm handler was more reliable in shutting down the arm after killing the rosnode.
This has been tested on our setup on a YRC1000 with 4 robot groups. Thanks for all your hard work!
This has been tested on our setup on a YRC1000 with 4 robot groups. Thanks for all your hard work!
Wow, thanks for the hardware testing!
Changes required to reliably control and execute joint trajectories on our multigroup system. This was tested and verified with a Yaskawa multi-group robot with one GP7 arm attached to a rail. This was not tested on a single-group robot to verify backwards compatibility - we suspect a small amount of work is still required to make these changes compatible with a single-group robot.
Changes were motivated by discussion in https://github.com/ros-industrial/motoman/issues/450
Notable updates include: