search

ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
146 stars 193 forks source link

MotoROS - Fix open bugs #520

Closed ted-miller closed 1 year ago

ted-miller commented 2 years ago

Fix for #492 and #519. ~Untested.~

ted-miller commented 2 years ago

This has been tested.

EricMarcil commented 2 years ago

@ted-miller I have not tested but the code changes make sense. Did you want me to also test the changes to double check your changes?

gavanderhoorn commented 1 year ago

@ted-miller: did you intend to close this?

Seems the PR came from your main kinetic-devel branch. Perhaps re-submit from a separate branch?

ted-miller commented 1 year ago

did you intend to close this?

Nope. I completely forgot that this existed and I did a force push to sync with upstream

cjue commented 1 year ago

@ted-miller we were using your PR internally and would therefore welcome a new/reopened PR.

This branch holds all commits previously in this PR, commit e946725: https://github.com/isys-vision/motoman/tree/PR-520_fix_open_bugs

ted-miller commented 1 year ago

New PR opened in #550.