ros-industrial / motoman

ROS-Industrial Motoman support (http://wiki.ros.org/motoman)
143 stars 194 forks source link

GP35L Support Package #535

Closed EricMarcil closed 7 months ago

EricMarcil commented 1 year ago

Add GP35L Support Package

gavanderhoorn commented 1 year ago

Something else I noticed:

image

the black motors and cable and white Yaskawa lettering are a nice touch, but as you can see, the black is so black, there is no detail visible at all like this.

Notice also the rendering artefacts on other parts of the geometry: could it be the meshes have been decimated/compressed too much?

EricMarcil commented 8 months ago

@gavanderhoorn Changed the black to dark gray. Also fixed the color of a few faces that got messed up by the decimated. It does look as if the model was a bit too decimated but that's how my original source file was. So we'll go with that for now.

cjue commented 7 months ago

seeing as this appears to be an L variant: are there any other variants of the GP35? If so, the support package name should drop the l.

Judging from this overview there is no "GP35" besides the GP35L, so package name should be fine.

EricMarcil commented 7 months ago

seeing as this appears to be an L variant: are there any other variants of the GP35? If so, the support package name should drop the l.

On that note, most of the models ending by an L are hybrid robot with longer reach and have nothing to do with a base model with the same number. The number in the model simply indicates the resulting payload of the hybrid model. The GP35L is actually closer to a GP50 but with an extension in the upper arm to give it more reach but reduced payload to 35 kg. If we were to include it in the GP50 support package, then I think most people would not find it. So, I think that having a package named GP35L is the best solution.