search

ros-industrial / motoman_experimental

Experimental packages for Motoman manipulators within ROS-Industrial
Apache License 2.0
15 stars 32 forks source link

Initial commit for MPP3H kinematic library and support #20

Open Chamango90 opened 7 years ago

Chamango90 commented 7 years ago

Kinematic library and support package for the Motoman MPP3H delta robot.

gavanderhoorn commented 7 years ago

Should this go into kinetic-devel? From the commits included I think you use kinetic-devel on your machine, but opened the PR against indigo-devel?

Chamango90 commented 7 years ago

Rebased to indigo-devel.

mathias-luedtke commented 7 years ago

test config is missing. @gavanderhoorn: should I provide one?

gavanderhoorn commented 7 years ago

@ipa-mdl wrote:

test config is missing. @gavanderhoorn: should I provide one?

thanks for the offer, but I think it'd be better if this PR would be targeted at kinetic-devel. We already have Travis set up there, and this repo doesn't really see any development for Indigo.

@ipa-jfh: would it be a big problem for you to submit against kinetic-devel? You don't need to re-open the PR, you could just edit it (top of the page).

Chamango90 commented 7 years ago

I could not test this packages on kinetic. @gavanderhoorn: Could you please make a quick test with test_mpp3h.launch of motoman_mpp3h_support?

gavanderhoorn commented 7 years ago

I can probably run it in a Docker container. I don't have the hardware though.

Do you have any experience with Docker? I (or maybe @ipa-mdl) could probably help you get to a point where you can run your package under Kinetic on a Trusty system.

gavanderhoorn commented 7 years ago

Btw: Travis is failing now because your install(..) line is trying to install a config dir that doesn't exist.

mathias-luedtke commented 7 years ago

@gavanderhoorn: We don't have the hardware anymore, the test_mpp3h.launch just starts a joint_state_publisher and RVIZ.

Chamango90 commented 7 years ago

Btw: Travis is failing now because your install(..) line is trying to install a config dir that doesn't exist.

Thank you. I fixed the install line.

gavanderhoorn commented 7 years ago

@ipa-mdl wrote:

@gavanderhoorn: We don't have the hardware anymore, [..]

so we can't actually test any changes that might be necessary after review of the current code then?

mathias-luedtke commented 7 years ago

so we can't actually test any changes that might be necessary after review of the current code then? Show all checks

Yes, we cannot test it properly with the hardware. But the code is about the kinematics and it can be tested without the hardware :)