ros-industrial / motoman_experimental

Experimental packages for Motoman manipulators within ROS-Industrial
Apache License 2.0
15 stars 32 forks source link

Add MH24 support #44

Closed VictorLamoine closed 5 years ago

VictorLamoine commented 5 years ago

Original work was done by @de-vri-es, are you ok with the fact that I push your work here? What I have done is just cleaning the xacro files, improved the meshes with Blender.

@gavanderhoorn the joints names are currently controller_joint_names: ['joint_s', 'joint_l', 'joint_u', 'joint_r', 'joint_b', 'joint_t'], should I rename them to 1, 2, 3 etc. ?

Visual

screenshot_20181119_110307

screenshot_20181119_110352

Collisions

screenshot_20181119_110316

de-vri-es commented 5 years ago

I'm a bit conflicted to be honest. The git history showing my contributions is gone, which I'm not that happy about. I'd rather you sent a PR to https://github.com/fizyr/yaskawa_mh24_support .

If you want to move it into ros-industrial, we can transfer ownership. But it might make sense to keep it as a separate package anyway, to prevent getting huge repositories with many meshes for different robots. If needed, it can be renamed as part of an ownership transfer.

VictorLamoine commented 5 years ago

Closing in favor of https://github.com/fizyr/yaskawa_mh24_support/pull/1